Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EsReviewsIoCardCarousel v3 #1522

Merged

Conversation

hroth1994
Copy link
Contributor

πŸ”— Linked issue

https://energysage.atlassian.net/browse/CED-1787

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Create EsReviewsIoCardCarousel with the same functionality as the existing component. There are no props for this component, so there is no props table.

πŸ₯Ό Testing

Tested locally on http://localhost:8500/organisms/reviews-io-card-carousel

🧐 Feedback Requested / Focus Areas

  • General

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

Copy link

swarmia bot commented Sep 10, 2024

βœ… Β Linked to Task CED-1787 Β· Create v3 EsReviewsIoCardCarousel
➑️  Part of Epic CED-1339 · Build Vue 3 design system [LC]

Copy link
Collaborator

@ericdouglaspratt ericdouglaspratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Two quick things.

es-ds-docs/components/ds-organisms-list.vue Outdated Show resolved Hide resolved
es-ds-styles/scss/_reviews.scss Outdated Show resolved Hide resolved
Copy link
Collaborator

@ericdouglaspratt ericdouglaspratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hroth1994 hroth1994 merged commit 6e2e398 into esds-3.0-vue3-primevue Sep 11, 2024
1 check passed
@hroth1994 hroth1994 deleted the ced-1787-es-reviews-io-card-carousel branch September 11, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants